From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] test: fix test_tlb_tx_burst
Date: Wed, 05 Aug 2015 11:28:40 +0200
Message-ID: <7330921.0l7ts1gtOu@xps13>
References: <1438765813-10932-1-git-send-email-michalx.k.jastrzebski@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id B7C855A5C
 for <dev@dpdk.org>; Wed,  5 Aug 2015 11:29:56 +0200 (CEST)
Received: by wicgj17 with SMTP id gj17so184209655wic.1
 for <dev@dpdk.org>; Wed, 05 Aug 2015 02:29:56 -0700 (PDT)
In-Reply-To: <1438765813-10932-1-git-send-email-michalx.k.jastrzebski@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-08-05 11:10, Michal Jastrzebski:
> This patch fixes error in tlb_tx_burst function:
> Distribution is not even.

What was the error exactly?

> A condition in TEST_ASSERT macro was changed,
> as the previous one was random.

I think "random" can be better described.

> Also the time of generating packets can now be decreased.

>  	/* Generate 400000 test bursts in 2s of packets to transmit  */
> -	for (i = 0; i < 400000; i++) {
> +	for (i = 0; i < 10000; i++) {

It is a good example of an useless comment which becomes easily out-of-date.