From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/2] net/bnxt: fix arguments to
 _rte_eth_dev_callback_process
Date: Mon, 31 Jul 2017 12:19:37 +0100
Message-ID: <734423cc-14d4-db38-b818-a021aeccb82c@intel.com>
References: <20170725033224.90613-1-ajit.khaparde@broadcom.com>
 <20170725033224.90613-3-ajit.khaparde@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 9AAA399B0
 for <dev@dpdk.org>; Mon, 31 Jul 2017 13:19:39 +0200 (CEST)
In-Reply-To: <20170725033224.90613-3-ajit.khaparde@broadcom.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/25/2017 4:32 AM, Ajit Khaparde wrote:
> The callback arguments to _rte_eth_dev_callback_process() are swapped.
> Fix them.
> 
> Fixes: d6af1a13d7a1 ("ethdev: add return values to callback process API")
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/rte_pmd_bnxt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c
> index dd7e5b8..0463373 100644
> --- a/drivers/net/bnxt/rte_pmd_bnxt.c
> +++ b/drivers/net/bnxt/rte_pmd_bnxt.c
> @@ -57,7 +57,7 @@ int bnxt_rcv_msg_from_vf(struct bnxt *bp, uint16_t vf_id, void *msg)
>  	cb_param.msg = msg;
>  
>  	_rte_eth_dev_callback_process(bp->eth_dev, RTE_ETH_EVENT_VF_MBOX,
> -			&cb_param, NULL);
> +				      NULL, &cb_param);

Hi Ajit,


Since you are using "cb_param.retval", change looks good.

But it is easy to confuse between cb_param and ret_param. To clarify
your intention, I suggest renaming "cb_param" to "ret_param", does it
make sense?

Thanks,
ferruh

>  
>  	/* Default to approve */
>  	if (cb_param.retval == RTE_PMD_BNXT_MB_EVENT_PROCEED)
>