From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] usertools: fix build with gcc
Date: Wed, 27 Jun 2018 15:31:55 +0200
Message-ID: <7357136.ipTnM7Ko6i@xps>
References: <1529573741-9606-1-git-send-email-choonho.son@gmail.com>
 <1529573741-9606-2-git-send-email-choonho.son@gmail.com>
 <20180621095502.GA436@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
To: Choonho Son <choonho.son@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 19B5B1BAFB
 for <dev@dpdk.org>; Wed, 27 Jun 2018 15:31:58 +0200 (CEST)
In-Reply-To: <20180621095502.GA436@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/06/2018 11:55, Bruce Richardson:
> On Thu, Jun 21, 2018 at 09:35:41AM +0000, Choonho Son wrote:
> > dpdk-setup.sh fails to build with lack of environment variable
> > 
> > Build complete [x86_64-native-linuxapp-gcc]
> > Installation cannot run with T defined and DESTDIR undefined
> > 
> > Signed-off-by: Choonho Son <choonho.son@gmail.com>
> > ---
[...]
> > -		make install T=${RTE_TARGET}
> > +		make install T=${RTE_TARGET} DESTDIR=${DESTDIR}
> 
> The message about no DESTDIR is not really an error, the build has
> completed successfully. I don't think copying the build over to a new
> directory is something we should always do as part of this script.

Absolutely!

The syntax "make install T=" is old.
It should be replaced by "make config T=" + "make".
You can look at devtools/test-build.sh to see how compilation can be done.
It is also documented in various places like:
	doc/guides/linux_gsg/build_dpdk.rst
	doc/guides/prog_guide/dev_kit_root_make_help.rst

More options:
	- use meson build system in dpdk-setup.sh - maybe too early
	- remove dpdk-setup.sh - maybe used by real users