From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH 3/4] ethdev: move representor parsing
	functions
Date: Tue, 9 Oct 2018 13:38:01 +0100
Message-ID: <73ffc68e-0a1f-de2a-790e-6bd4941fddef@intel.com>
References: <20181009021858.19216-1-thomas@monjalon.net>
 <20181009021858.19216-4-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, ferruh.yigit@intel.com,
 arybchenko@solarflare.com, olivier.matz@6wind.com
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 590D41B472
 for <dev@dpdk.org>; Tue,  9 Oct 2018 14:49:53 +0200 (CEST)
In-Reply-To: <20181009021858.19216-4-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 09/10/2018 03:18, Thomas Monjalon wrote:
> The functions for representor devargs parsing were static
> in the file rte_ethdev.c.
> In order to reuse them in the file rte_class_eth.c,
> they are moved to the files ethdev_private.c/.h.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

There is overlap between these functions and some of the rte_kvargs_*() 
functions. Is it feasible/desirable to combine them?

..Remy