From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] devargs: restore rte_devtype API Date: Thu, 20 Jul 2017 00:32:12 +0300 Message-ID: <7428826.qyDVAEg8QH@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, jblunck@infradead.org To: Gaetan Rivet Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 65C1B231E for ; Wed, 19 Jul 2017 23:32:14 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/07/2017 20:59, Gaetan Rivet: > Revert "devargs: make device types generic" > > This commit broke the rte_devargs API by changing the meaning of > the rte_devtype enum. > > Restore the previous API, unit tests and function calls. > Introduce parallel enum that acts as translation between previous API > and current structures. > > Restoring the previous API means that -w and -b are not usable anymore > with any bus having implemented the "parse" operation. Only PCI devices > can be used with -w and -b, virtual devices are declared using vdev. > > This (partially) reverts commit bd279a79366f50a4893fb84db91bbf64b56f9fb1. > > Signed-off-by: Gaetan Rivet > --- > > As correctly pointed out by Jan Blunck in [1], the previous change breaks an existing API. > This commit only deals with this API. Doing so however, restore the previous behavior as well. > This means that the devargs behavior is iso-functional with that of the v17.05. > It is possible, however, to explicitly set the bus in a device declaration. > > [1]: http://dpdk.org/ml/archives/dev/2017-July/071318.html Applied, thanks