From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH] maintainers: fix responsibility of flow API bits Date: Thu, 17 May 2018 15:45:30 +0100 Message-ID: <7431a0f3-e87e-6b8b-04ae-9fd6e919a699@intel.com> References: <1525944544-13513-1-git-send-email-bernard.iremonger@intel.com> <20180515162211.7030-1-adrien.mazarguil@6wind.com> <8CEF83825BEC744B83065625E567D7C24E0CD20F@IRSMSX108.ger.corp.intel.com> <20180516143517.GA6497@6wind.com> <8CEF83825BEC744B83065625E567D7C24E0CD818@IRSMSX108.ger.corp.intel.com> <20180517112045.GE6497@6wind.com> <8CEF83825BEC744B83065625E567D7C24E0CD93C@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "stable@dpdk.org" To: "Iremonger, Bernard" , Adrien Mazarguil Return-path: In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0CD93C@IRSMSX108.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/17/2018 12:26 PM, Iremonger, Bernard wrote: > Hi Adrien, > > > > >>>>>> Subject: [PATCH] maintainers: fix responsibility of flow API >>>>>> bits >>>>>> >>>>>> The following commits lack MAINTAINERS entries for this mess. >>>>>> >>>>>> Fixes: 4d73b6fb9907 ("doc: add generic flow API guide") >>>>>> Fixes: 19c90af6285c ("app/testpmd: add flow command") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Adrien Mazarguil >>>>>> Cc: Bernard Iremonger >>>>>> --- >>>>>> MAINTAINERS | 2 ++ >>>>>> 1 file changed, 2 insertions(+) >>>>>> >>>>>> diff --git a/MAINTAINERS b/MAINTAINERS index >>>>>> bd08d4292..187817fff >>>>>> 100644 >>>>>> --- a/MAINTAINERS >>>>>> +++ b/MAINTAINERS >>>>>> @@ -303,6 +303,8 @@ F: devtools/test-null.sh Flow API >>>>>> M: Adrien Mazarguil >>>>>> T: git://dpdk.org/next/dpdk-next-net >>>>>> +F: app/test-pmd/cmdline_flow.c >>>>>> +F: doc/guides/prog_guide/rte_flow.rst >>>>> >>>>> doc/guides/testpmd_app_ug/testpmd_funcs.rst >>>>> Should be added to the list of flow related files. >>>> >>>> I did not add it because there is no way to split responsibility on >>>> a documentation section basis AFAIK, and only a fraction of this >>>> file contains information about rte_flow-related stuff. >>>> >>>> -- >>>> Adrien Mazarguil >>>> 6WIND >>> >>> There are already several maintainers for testpmd, adding another maintainer >> for the flow parts of this file should be ok (I think). >> >> True, however providing an exact file name instead of a directory or wildcard >> makes me the main maintainer/contact for that specific file (e.g. "app/test- >> pmd/cmdline_flow.c" vs. "app/test-pmd"), basically I do not want to be >> responsible for the entirety of testpmd's documentation. >> >> How about the following instead: another patch that extracts the flow >> command documentation in its own file (testpmd_flow.rst?) using the include >> directive (somewhat like cmdline_flow.c). This patch will update MAINTAINERS >> accordingly. >> >> -- >> Adrien Mazarguil >> 6WIND > > Sounds good to me. Applied to dpdk-next-net/master, thanks. (Another patch will separate testpmd_flow.rst? and add maintainership for it)