From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/6] Xen DOM0 runtime support Date: Wed, 21 Oct 2015 16:40:08 +0200 Message-ID: <7433431.i8vU4GXoZ3@xps13> References: <1443487487-31915-1-git-send-email-stephen@networkplumber.org> <20150930103042.0672a078@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Stephen Hemminger Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 56CED9432 for ; Wed, 21 Oct 2015 16:41:13 +0200 (CEST) Received: by wicfv8 with SMTP id fv8so78468067wic.0 for ; Wed, 21 Oct 2015 07:41:13 -0700 (PDT) In-Reply-To: <20150930103042.0672a078@urahara> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-09-30 10:30, Stephen Hemminger: > On Wed, 30 Sep 2015 10:14:09 +0200 > David Marchand wrote: > > On Tue, Sep 29, 2015 at 2:44 AM, Stephen Hemminger < > > stephen@networkplumber.org> wrote: > > > It should be possible to build a single application or library > > > that will work both in Xen and non-Xen environment. Any special > > > case handling should be done at runtime. > > > > This patchset looks good, but can you go a step further and completely > > remove the RTE_LIBRTE_XEN_DOM0 build option ? > > This requires some more work (igb_uio, app/test), but I think this is worth > > it all the more so as you are looking into it at the moment. > > I was thinking that for people on embedded systems having > the build option (which stubs out support) was a good thing. No we must remove the config options. It is not in a hot path so there is no reason to disable this support. Please respin.