From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 10/16] net/axgbe: add transmit and receive
 data path apis
Date: Fri, 8 Dec 2017 13:08:16 -0800
Message-ID: <74aa2336-3ee5-70a4-a653-4bcf6a470bfd@intel.com>
References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com>
 <1512047472-118050-10-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Ravi Kumar <Ravi1.kumar@amd.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 1220A1B1C3
 for <dev@dpdk.org>; Fri,  8 Dec 2017 22:08:18 +0100 (CET)
In-Reply-To: <1512047472-118050-10-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/30/2017 5:11 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> ---
>  drivers/net/axgbe/Makefile         |   1 +
>  drivers/net/axgbe/axgbe_ethdev.c   |  56 ++++-
>  drivers/net/axgbe/axgbe_rxtx.c     | 427 +++++++++++++++++++++++++++++++++++++
>  drivers/net/axgbe/axgbe_rxtx.h     |  19 ++
>  drivers/net/axgbe/axgbe_rxtx_vec.c | 215 +++++++++++++++++++

You may rename this as axgbe_rxtx_vec_sse.c to clarify which arch it is for.

<...>

> @@ -190,6 +192,7 @@ static const struct eth_dev_ops axgbe_eth_dev_ops = {
>  	.dev_start            = axgbe_dev_start,
>  	.dev_stop             = axgbe_dev_stop,
>  	.dev_close            = axgbe_dev_close,
> +	.link_update          = axgbe_dev_link_update,

Can you please separate this into its own patch.

<...>

> @@ -545,8 +595,8 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)
>  	axgbe_set_bit(AXGBE_STOPPED, &pdata->dev_state);
>  	pdata->eth_dev = eth_dev;
>  	eth_dev->dev_ops = &axgbe_eth_dev_ops;
> -	eth_dev->rx_pkt_burst = NULL;
> -	eth_dev->tx_pkt_burst = NULL;
> +	eth_dev->rx_pkt_burst = &axgbe_recv_pkts;
> +	eth_dev->tx_pkt_burst = &axgbe_xmit_pkts_vec;

It can be helpful to comment axgbe_dev_tx_queue_setup() can set non-vector Tx path.

<...>