From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH 1/2] test/memzone: add test for memzone count
 in eal mem config
Date: Mon, 29 Jan 2018 09:40:01 +0000
Message-ID: <74c843c4-6ecf-e645-0220-c232a4448f3a@intel.com>
References: <ec8bf2436653ce9dbbe9e83a364ca44c41bd2a8a.1516988093.git.anatoly.burakov@intel.com>
 <CAEK-wKn8d+vUEWbhSYRzP_4Td3L8yXH8shzbKnQWpfYn-dF-CA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Radoslaw Biernacki <radoslaw.biernacki@linaro.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 8DEC11B40C
 for <dev@dpdk.org>; Mon, 29 Jan 2018 10:40:04 +0100 (CET)
In-Reply-To: <CAEK-wKn8d+vUEWbhSYRzP_4Td3L8yXH8shzbKnQWpfYn-dF-CA@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 27-Jan-18 2:53 PM, Radoslaw Biernacki wrote:
> Looks OK.
> 
> Following note is aside from the patch.
> Might be beneficial (in some rare cases) to add bailout recovery with
> goto's in test_memzone_basic()
> Just in case one of the rte_memzone_reserve() we should not make return -1,
> but instead a goto to below section where we call rte_memzone_free().
> This way we would be able to free only the allocated memzones and prevent
> leaking out those memzones to other tests.

Thanks, and yep, it's on my todo list :) didn't get around to it yet.

> 
> Reviewed-by: Radoslaw Biernacki <r <ferruh.yigit@intel.com>
> adoslaw.biernacki@linaro.com>
> 


-- 
Thanks,
Anatoly