From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5] doc/patches: add meson build to
	contributing guide
Date: Tue, 12 Feb 2019 10:36:29 +0100
Message-ID: <7524951.pvg4nOelVy@xps>
References: <20190124230541.58343-1-vipin.varghese@intel.com>
 <20190129101036.35002-1-vipin.varghese@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com,
 ferruh.yigit@intel.com, sanjay.padubidri@intel.com, amol.patel@intel.com,
 bruce.richardson@intel.com
To: Vipin Varghese <vipin.varghese@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 5B8F51B457
 for <dev@dpdk.org>; Tue, 12 Feb 2019 10:36:32 +0100 (CET)
In-Reply-To: <20190129101036.35002-1-vipin.varghese@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

29/01/2019 11:10, Vipin Varghese:
> +Meson system
> +~~~~~~~~~~~~

What do you think about adding "Makefile system" title for previous section?
We could also add an introduction explaining that both systems must be tested.

> +
> +Compilation of patches is to be tested with ``devtools/test-meson-builds.sh`` script in ``devtools``

A dot is missing. You may remove "in ``devtools``" as it is already in the path.

> +
> +The script internally checks for dependencies, then builds for several
> +combinations of compilation configuration.
> +