From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] l3fwd: set cli back to unix style
Date: Mon, 15 Jan 2018 12:24:16 +0100
Message-ID: <758014701.CxxNsLCgt3@xps>
References: <20171211231258.16494-1-sthemmin@microsoft.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 67E32322C
 for <dev@dpdk.org>; Mon, 15 Jan 2018 12:24:48 +0100 (CET)
In-Reply-To: <20171211231258.16494-1-sthemmin@microsoft.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/12/2017 00:12, Stephen Hemminger:
> The l3fwd program became chatty, and the code looks cluttered in
> recent versions. DPDK programs should try for Unix (not VMS) style
> and not print messages for the options user selected. Also, errors should
> be printed on stderr. To make it easier to find code matching error
> messages; error strings should be placed in situ rather than saved
> as string vaiables.
> 
> Fixes: 268888b5b020 ("examples/l3fwd: modularize")
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

Applied, thanks