From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 20/25] bnxt: add support to get and clear
 VF specific stats
Date: Wed, 31 May 2017 10:57:04 +0100
Message-ID: <759bde90-b1e2-1a69-f98e-a02e164608c8@intel.com>
References: <CACZ4nhuCdAoJJtmi2joaHf9+4+MzVFz87S-XO_J-HRBGUdiEFg@mail.gmail.com>
 <20170526183941.80678-1-ajit.khaparde@broadcom.com>
 <20170526183941.80678-21-ajit.khaparde@broadcom.com>
 <3d568535-8eda-d79f-bbe5-43f9f1071184@intel.com>
 <CACZ4nhuws4LUyOUr10i10gME+Xtz0UHYXfORAk7Lazuzux284A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Stephen Hurd <stephen.hurd@broadcom.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id E30C15424
 for <dev@dpdk.org>; Wed, 31 May 2017 11:57:08 +0200 (CEST)
In-Reply-To: <CACZ4nhuws4LUyOUr10i10gME+Xtz0UHYXfORAk7Lazuzux284A@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/31/2017 3:12 AM, Ajit Khaparde wrote:
> 
> On Mon, May 29, 2017 at 12:43 PM, Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
> 
>     > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count)
>     > +{
>     > +     struct rte_eth_dev *dev;
>     > +     struct rte_eth_dev_info dev_info;
>     > +     struct bnxt *bp;
>     > +
>     > +     dev = &rte_eth_devices[port];
>     > +     rte_eth_dev_info_get(port, &dev_info);
>     > +     bp = (struct bnxt *)dev->data->dev_private;
>     > +
>     > +     return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, count);
>     > +}
> 
>     This function is not to get VF stats from PF. As far as I can see this
>     just gets queue stats, does this really needs to be PMD specific API,
>     isn't this something generic?
> 
> 
> ​Yes. That is right. It returns a count of number of packets which were
> not transmitted
> because it did not pass the MAC/VLAN spoof check. 
> It does not
> necessarily mean "failure to transmit" and so I don't think it is right
> to map it to oerrors.
> So in the current form I don't see a way to make a generic function out
> of it.​

I see, this is implemented because there is no place in basic stats to
put tx_drop_pkts.

Can xstats be used to get this value? Can new .xstats_get_by_id help here?