DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marat Khalili <marat.khalili@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: RE: [PATCH 2/2] bpf: silence noisy message
Date: Thu, 2 Jul 2026 08:36:14 +0000	[thread overview]
Message-ID: <75fa182ed2b64f88bdb0c6c8a729aaea@huawei.com> (raw)
In-Reply-To: <20260701223453.104660-2-stephen@networkplumber.org>



> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday 1 July 2026 23:35
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Konstantin Ananyev <konstantin.ananyev@huawei.com>;
> Marat Khalili <marat.khalili@huawei.com>
> Subject: [PATCH 2/2] bpf: silence noisy message
> 
> The recent loader change causes a log message every time BPF
> is used. For example, running dpdk-dumpcap cause:
>  BPF: rte_bpf_load_ex(): successfully creates ...
> 
> This is a debug message and should not normally be needed.
> 
> Fixes: 55192fe168b9 ("bpf: introduce extensible load API")

The commit message and Fixes tag are not 100% accurate, this message existed before:
https://github.com/DPDK/dpdk/blob/09e4f37ddd0f7d5cc7c696741f31f1582c73a716/lib/bpf/bpf_load_elf.c#L331-L333

(In fact I tried to eliminate it, but had to but back at the insistence of AI reviewer
and even broke the build in the process...)

So naturally I support downgrading this message. With the commit message corrected,

Acked-by: Marat Khalili <marat.khalili@huawei.com>

> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/bpf/bpf_load.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/bpf/bpf_load.c b/lib/bpf/bpf_load.c
> index 2fd0ee0720..36f6556fd5 100644
> --- a/lib/bpf/bpf_load.c
> +++ b/lib/bpf/bpf_load.c
> @@ -286,7 +286,7 @@ rte_bpf_load_ex(const struct rte_bpf_prm_ex *prm)
>  		return NULL;
>  	}
> 
> -	RTE_BPF_LOG_FUNC_LINE(INFO, "successfully creates %p(jit={.func=%p,.sz=%zu});",
> +	RTE_BPF_LOG_FUNC_LINE(DEBUG, "successfully creates %p(jit={.func=%p,.sz=%zu});",
>  		load.bpf, load.bpf->jit.raw, load.bpf->jit.sz);
>  	return load.bpf;
>  }
> --
> 2.53.0


  reply	other threads:[~2026-07-02  8:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 22:34 [PATCH 1/2] bpf: default log level should be NOTICE Stephen Hemminger
2026-07-01 22:34 ` [PATCH 2/2] bpf: silence noisy message Stephen Hemminger
2026-07-02  8:36   ` Marat Khalili [this message]
2026-07-02 16:30     ` Stephen Hemminger
2026-07-02 16:34       ` Marat Khalili
2026-07-02  8:40 ` [PATCH 1/2] bpf: default log level should be NOTICE Marat Khalili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75fa182ed2b64f88bdb0c6c8a729aaea@huawei.com \
    --to=marat.khalili@huawei.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox