From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 1/7] ethdev: add additional error stats
Date: Wed, 17 Jun 2015 16:01:18 +0200
Message-ID: <7603426.jST2jPJP37@xps13>
References: <1433862646-91880-1-git-send-email-maryam.tahhan@intel.com>
 <1433862646-91880-2-git-send-email-maryam.tahhan@intel.com>
 <20150609172954.173d26d0@urahara>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Maryam Tahhan <maryam.tahhan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 6A629C458
 for <dev@dpdk.org>; Wed, 17 Jun 2015 16:02:18 +0200 (CEST)
Received: by wiga1 with SMTP id a1so140735173wig.0
 for <dev@dpdk.org>; Wed, 17 Jun 2015 07:02:18 -0700 (PDT)
In-Reply-To: <20150609172954.173d26d0@urahara>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-06-09 17:29, Stephen Hemminger:
> On Tue,  9 Jun 2015 16:10:40 +0100
> Maryam Tahhan <maryam.tahhan@intel.com> wrote:
> 
> > Add MAC error and drop statistics to struct rte_eth_stats and the
> > extended stats.
> > Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> > ---
> >  lib/librte_ether/rte_ethdev.c | 4 ++++
> >  lib/librte_ether/rte_ethdev.h | 4 ++++
> >  2 files changed, 8 insertions(+)
> > 
> > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> > index 5a94654..a439b4a 100644
> > --- a/lib/librte_ether/rte_ethdev.c
> > +++ b/lib/librte_ether/rte_ethdev.c
> > @@ -136,6 +136,10 @@ static const struct rte_eth_xstats_name_off rte_stats_strings[] = {
> >  	{"rx_flow_control_xon", offsetof(struct rte_eth_stats, rx_pause_xon)},
> >  	{"tx_flow_control_xoff", offsetof(struct rte_eth_stats, tx_pause_xoff)},
> >  	{"rx_flow_control_xoff", offsetof(struct rte_eth_stats, rx_pause_xoff)},
> > +	{"rx_mac_err", offsetof(struct rte_eth_stats, imacerr)},
> > +	{"rx_phy_err", offsetof(struct rte_eth_stats, iphyerr)},
> > +	{"tx_drops", offsetof(struct rte_eth_stats, odrop)},
> > +	{"rx_drops", offsetof(struct rte_eth_stats, idrop)}
> 
> Are these really generic enough to put them in ethdev?

No, as explained here:
	http://dpdk.org/ml/archives/dev/2015-June/019550.html
Please rework.
Thanks