From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 0/4] examples/power: allow use of more
	than 64 cores
Date: Wed, 19 Dec 2018 22:25:18 +0100
Message-ID: <7613010.y8C9Z1eyu9@xps>
References: <20181214114946.21570-1-david.hunt@intel.com>
 <20181214133137.23516-1-david.hunt@intel.com>
 <36e6f6f0-8632-96d5-697f-905745778bbe@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 lei.a.yao@intel.com
To: David Hunt <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 25D742C16
 for <dev@dpdk.org>; Wed, 19 Dec 2018 22:25:21 +0100 (CET)
In-Reply-To: <36e6f6f0-8632-96d5-697f-905745778bbe@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/12/2018 14:37, Burakov, Anatoly:
> On 14-Dec-18 1:31 PM, David Hunt wrote:
> > First of all we convert all the relevant uint64_t's to char arrays. Then
> > we remove the unneeded mask functions that were limited to 64 cores. Also
> > extend the guest functionality and finally rause the number of supported
> > cores to something more sensible, i.e. 256.
> > 
> > v2 changes:
> >    * Updates out of Review by Anatoly.
> >    * Indentation fixes
> >    * resolved missing spinlock around config updates
> >    * simplified some loops
> >    * fixed bug in non-equivalent code
> > 
> > v3 changes:
> >    * Moved a spinlock to a more appropriate place. Was in a for-loop, made
> >      more sense to have it outside.
> > 
> > [1/4] examples/power: change 64-bit masks to arrays
> > [2/4] examples/power: remove mask functions
> > [3/4] examples/power: allow vms to use lcores over 63
> > [4/4] examples/power: increase max cores to 256
> 
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks