From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v9 6/8] app/pdump: add pdump tool for packet
	capturing
Date: Tue, 14 Jun 2016 12:56:01 -0700 (PDT)
Message-ID: <7622564.Y5NIsWpo6J@xps13>
References: <1465575534-23605-1-git-send-email-reshma.pattan@intel.com>
 <1465897108-26548-1-git-send-email-reshma.pattan@intel.com>
 <1465897108-26548-7-git-send-email-reshma.pattan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Reshma Pattan <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 512AEADA7
 for <dev@dpdk.org>; Tue, 14 Jun 2016 21:56:03 +0200 (CEST)
Received: by mail-wm0-f52.google.com with SMTP id v199so135790971wmv.0
 for <dev@dpdk.org>; Tue, 14 Jun 2016 12:56:03 -0700 (PDT)
In-Reply-To: <1465897108-26548-7-git-send-email-reshma.pattan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-14 10:38, Reshma Pattan:
> New tool added for packet capturing on dpdk.
> This tool supports command line options.
> This tool runs as secondary process by default.
> 
> Command line supports various parameters to capture
> the packets.
> 
> User should pass on a)port and queue (or) b)pci address
> and queue (or) c)device name and queue to capture
> the packets.
> 
> Users also need to pass on either pcap file name or
> any linux iface, on to which packets captured from dpdk
> ports will be sent on for the users to view using tcpdump.
> 
> Users have option to capture packets either a) in Rx
> direction, b)(or) in Tx direction c)(or) from both the
> directions.
> 
> User can pass on ring_size and mempool parameters using
> command line, but these are optional parameters.
> These are used to create ring and mempool objects for packet
> mirroring from primary application to tool. If user doesn't
> provide any values, default values will be used internally
> for the creation of the ring and mempool.

The explanations should be in an user guide.

> --- a/app/Makefile
> +++ b/app/Makefile
> @@ -37,5 +37,6 @@ DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += test-pipeline
>  DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
>  DIRS-$(CONFIG_RTE_LIBRTE_CMDLINE) += cmdline_test
>  DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
> +DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += pdump

Why Linux only?

There is a build error if CONFIG_RTE_LIBRTE_PDUMP is disabled.