From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: copy optarg when parsing mempool ops name Date: Mon, 14 May 2018 01:07:48 +0200 Message-ID: <7636615.bGWiXIQp7Z@xps> References: <1525429914-18409-1-git-send-email-arybchenko@solarflare.com> <146d5ea9-793b-9bbc-0d20-9375cf2d3907@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, santosh , stable@dpdk.org To: Andrew Rybchenko , Ivan Malov Return-path: In-Reply-To: <146d5ea9-793b-9bbc-0d20-9375cf2d3907@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/05/2018 07:42, santosh: > > On Friday 04 May 2018 04:01 PM, Andrew Rybchenko wrote: > > From: Ivan Malov > > > > The code aimed to pick and remember the value of > > mempool ops name from EAL command line arguments does not > > copy the string and remembers the pointer provided > > by getopt_long() directly. The latter could be clobbered > > later and result in reading wrong mbuf pool ops name > > by rte_mempool library. > > > > Typically, this flaw could be avoided by using strdup() > > to remember the string value of the option. > > > > Fixes: a103a97e7191 ("eal: allow user to override default mempool driver") > > Cc: Santosh Shukla > > Cc: stable@dpdk.org > > > > Signed-off-by: Ivan Malov > > Signed-off-by: Andrew Rybchenko > > --- > > Acked-by: Santosh Shukla Applied, thanks