From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 0/7] build fixes
Date: Thu, 03 Jul 2014 00:13:59 +0200
Message-ID: <7641305.RuYz2FeinY@xps13>
References: <1404313375-2205-1-git-send-email-thomas.monjalon@6wind.com>
 <59AF69C657FD0841A61C55336867B5B02CF134F1@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Richardson, Bruce" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CF134F1-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-07-02 17:57, Richardson, Bruce:
> > -----Original Message-----
> > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Thomas Monjalon
> > Sent: Wednesday, July 02, 2014 8:03 AM
> > To: dev-VfR2kkLFssw@public.gmane.org
> > Subject: [dpdk-dev] [PATCH 0/7] build fixes
> > 
> > When enabling pcap PMD or debug options, there are many compiler errors.
> > There is also another error on BSD.
> > 
> > These errors are due to many recent developments (link bonding,
> > rate limitation, ixgbe upgrade, vmxnet3, FILE argument for debug).
> > 
> > So my comments are:
> >   - I don't test every build configuration when accepting patches
> >   - Many developers don't test debug configurations
> > 
> > We should try to improve this process in the future.
> > 
> > Please give quick feedbacks on this serie.
> > It requires a new release candidate.
> 
> Acked-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Tested compilation on Fedora Linux and FreeBSD 10 both in default
> configuration and with all debug options set for PMDs. No compile errors
> encountered with main compilation.

Applied for version 1.7.0.

Thanks

> However, two further minor issues spotted:
> * Running "gmake" in the examples directory gives errors for applications
> that only work in Linux.
> * The common_bsdapp file has all debug options
> turned on for the i40e driver by default.

I've fixed these BSD issues:
	http://dpdk.org/browse/dpdk/commit/?id=304caba12
	http://dpdk.org/browse/dpdk/commit/?id=3417cd687
Thanks for reporting
-- 
Thomas