From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 2/3] i40e: extern two functions and
	relevant macros
Date: Fri, 17 Oct 2014 22:59:09 +0200
Message-ID: <7641617.oBnDKljgVa@xps13>
References: <1411089280-23595-1-git-send-email-helin.zhang@intel.com>
 <1411089280-23595-3-git-send-email-helin.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1411089280-23595-3-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-09-19 09:14, Helin Zhang:
> To reuse code, 'i40e_config_hena()' and 'i40e_parse_hena()' and
> their relevant macros need to be extern, and then can be used for
> both PF and VF parts.
> 
> Signed-off-by: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Cunming Liang <cunming.liang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Jijiang Liu <jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
[...]
> +#define I40E_RSS_OFFLOAD_ALL ( \
> +	ETH_RSS_NONF_IPV4_UDP | \
> +	ETH_RSS_NONF_IPV4_TCP | \
> +	ETH_RSS_NONF_IPV4_SCTP | \
> +	ETH_RSS_NONF_IPV4_OTHER | \
> +	ETH_RSS_FRAG_IPV4 | \
> +	ETH_RSS_NONF_IPV6_UDP | \
> +	ETH_RSS_NONF_IPV6_TCP | \
> +	ETH_RSS_NONF_IPV6_SCTP | \
> +	ETH_RSS_NONF_IPV6_OTHER | \
> +	ETH_RSS_FRAG_IPV6 | \
> +	ETH_RSS_L2_PAYLOAD)
> +
> +/* All bits of RSS hash enable */
> +#define I40E_RSS_HENA_ALL ( \
> +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_UDP) | \
> +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_TCP) | \
> +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_SCTP) | \
> +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_OTHER) | \
> +	(1ULL << I40E_FILTER_PCTYPE_FRAG_IPV4) | \
> +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_UDP) | \
> +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_TCP) | \
> +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_SCTP) | \
> +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_OTHER) | \
> +	(1ULL << I40E_FILTER_PCTYPE_FRAG_IPV6) | \
> +	(1ULL << I40E_FILTER_PCTYPE_FCOE_OX) | \
> +	(1ULL << I40E_FILTER_PCTYPE_FCOE_RX) | \
> +	(1ULL << I40E_FILTER_PCTYPE_FCOE_OTHER) | \
> +	(1ULL << I40E_FILTER_PCTYPE_L2_PAYLOAD))

You've added the constants in the .h file but you forgot to remove them from
the .c file.

-- 
Thomas