From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] examples/vm_power_manager: fix build with
	libvirt version < 0.9.3
Date: Mon, 11 Apr 2016 09:24:24 +0200
Message-ID: <76861959.Vz3qnGk6Ag@xps13>
References: <1460346357-26592-1-git-send-email-yong.liu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Marvin Liu <yong.liu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id EDCDF1C52
 for <dev@dpdk.org>; Mon, 11 Apr 2016 09:24:26 +0200 (CEST)
Received: by mail-wm0-f47.google.com with SMTP id n3so91729482wmn.0
 for <dev@dpdk.org>; Mon, 11 Apr 2016 00:24:26 -0700 (PDT)
In-Reply-To: <1460346357-26592-1-git-send-email-yong.liu@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-04-11 11:45, Marvin Liu:
> vm_power_manager utilize libvirt API virDomainGetVcpuPinInfo for
> retrieve domU vcpu information. This API implemented from version 0.9=
.3.
> Suse11 SP3 32bit default libvirt version is 0.8.8, so there'll be bui=
ld
> error. Add judgement in sample Makefile to skip unsupport environment=
.
>=20
> examples/vm_power_manager/channel_manager.c: In function
> =E2=80=98update_pcpus_mask=E2=80=99:
> channel_manager.c:117:3: error: implicit declaration of function
> =E2=80=98virDomainGetVcpuPinInfo=E2=80=99
>=20
> Fixes: 2e099bc5d104 ("fix split of compiler and linker options")

I think the issue has always been there:
Fixes: e8ae9b662506 ("examples/vm_power: channel manager and monitor in=
 host")

> +LIBVIRT_COMMON =3D libvirt-common.h
> +LIBVIRT_HEADER =3D libvirt.h
> +INCLUDE_PATH =3D /usr/include/libvirt/

You cannot assume it will be installed in this directory.
Please check the version with the standard pkg-config:
=09pkg-config --atleast-version=3D0.9.3 libvirt
It can work even in cross compilation environment thanks to PKG_CONFIG_=
PATH.