From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH] doc: fix a typo in testpmd
 user guide
Date: Thu, 3 Jan 2019 16:35:35 +0000
Message-ID: <76962ff3-8001-fa97-aaf5-d88492e42a80@intel.com>
References: <20181227195905.4330-1-ramirose@gmail.com>
 <8CEF83825BEC744B83065625E567D7C260D49F5A@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: "stable@dpdk.org" <stable@dpdk.org>,
 "wisamm@mellanox.com" <wisamm@mellanox.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 Rami Rosen <ramirose@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D49F5A@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/3/2019 2:00 PM, Iremonger, Bernard wrote:
> Hi Rami,
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
>> Sent: Thursday, December 27, 2018 7:59 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; wisamm@mellanox.com; Rami Rosen
>> <ramirose@gmail.com>
>> Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide
>>
>> This patch fixes a typo in testpmd user guide.
>>
>> Fixes: aac6f11f5864 ("app/testpmd: add ethernet peer command")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>> ---
>>  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> index cbf23e928..ab40b9f5f 100644
>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> @@ -1149,7 +1149,7 @@ set eth-peer
>>
>>  Set the forwarding peer address for certain port::
>>
>> -   testpmd> set eth-peer (port_id) (perr_addr)
>> +   testpmd> set eth-peer (port_id) (peer_addr)
>>
>>  This is equivalent to the ``--eth-peer`` command-line option.
>>
>> --
>> 2.19.2
> 
> ./dpdk/devtools/checkpatches.sh /home/bairemon/patches_19_02_rc1_patchwork_testpmd/doc-fix-a-typo-in-testpmd-user-guide.patch
> 
> ### doc: fix a typo in testpmd user guide
> 
> WARNING:BAD_SIGN_OFF: Duplicate signature
> #25: 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> 
> total: 0 errors, 1 warnings, 8 lines checked

There is no double sign-off, this is because Wisam added his ack without quoting
original mail, so patchwork observed second sign-off and added it.

So original patch is OK, please check the error message before copy-paste it
from the console.

And with your error copy-paste, patchwork observed sign-off again and now there
are three copy same sign-off :)

> 
> Otherwise
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>  
>