From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH] vdev: free reply.msgs memory for secondary process Date: Fri, 21 Sep 2018 12:07:40 +0100 Message-ID: <769d244e-5e32-90bd-6ea0-1c99539404ef@intel.com> References: <20180920232930.68311-1-peluse@cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: paul luse , dev@dpdk.org Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2548B1B53 for ; Fri, 21 Sep 2018 13:07:47 +0200 (CEST) In-Reply-To: <20180920232930.68311-1-peluse@cox.net> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21-Sep-18 12:29 AM, paul luse wrote: > This patch fixes an issue caught with ASAN where a vdev_scan() > to a secondary bus was failing to free some memory. > > Signed-off-by: paul luse > --- > drivers/bus/vdev/vdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c > index 69dee89a8..2566d6c0d 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -423,6 +423,7 @@ vdev_scan(void) > mp_rep = &mp_reply.msgs[0]; > resp = (struct vdev_param *)mp_rep->param; > VDEV_LOG(INFO, "Received %d vdevs", resp->num); > + free(mp_reply.msgs); > } else > VDEV_LOG(ERR, "Failed to request vdev from primary"); > > Acked-by: Anatoly Burakov -- Thanks, Anatoly