From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [PATCH v5 5/8] testpmd: new commands to load/unload
 BPF filters
Date: Wed, 9 May 2018 19:31:14 +0100
Message-ID: <76a56efc-70ab-dc24-dda7-526386262b64@redhat.com>
References: <1523630598-24606-2-git-send-email-konstantin.ananyev@intel.com>
 <1525437945-8207-6-git-send-email-konstantin.ananyev@intel.com>
 <0592a009-5fa8-a109-a1e2-9d2bbc6c4cc5@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 3196AEE2B
 for <dev@dpdk.org>; Wed,  9 May 2018 20:31:17 +0200 (CEST)
In-Reply-To: <0592a009-5fa8-a109-a1e2-9d2bbc6c4cc5@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 05/09/2018 06:09 PM, Ferruh Yigit wrote:
> On 5/4/2018 1:45 PM, Konstantin Ananyev wrote:
>> Introduce new testpmd commands to load/unload RX/TX BPF-based filters.
>>
>> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>> ---
>>  app/test-pmd/bpf_sup.h   |  25 ++++++++
>>  app/test-pmd/cmdline.c   | 149 +++++++++++++++++++++++++++++++++++++++++++++++
>>  app/test-pmd/meson.build |   2 +-
>>  3 files changed, 175 insertions(+), 1 deletion(-)
>>  create mode 100644 app/test-pmd/bpf_sup.h
>>
>> diff --git a/app/test-pmd/bpf_sup.h b/app/test-pmd/bpf_sup.h
>> new file mode 100644
>> index 000000000..35f91a07f
>> --- /dev/null
>> +++ b/app/test-pmd/bpf_sup.h
>> @@ -0,0 +1,25 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright(c) 2010-2017 Intel Corporation
>> + */
>> +
>> +#ifndef _BPF_SUP_H_
>> +#define _BPF_SUP_H_
>> +
>> +#include <stdio.h>
>> +#include <rte_mbuf.h>
>> +#include <rte_bpf_ethdev.h>
> 
> This makes testpmd depends to librte_bpf unconditionally. What do you think
> using RTE_LIBRTE_BPF macro to make it possible to disable bpf library?
> 

+1

> <...>
> 
>> @@ -16695,6 +16842,8 @@ cmdline_parse_ctx_t main_ctx[] = {
>>  	(cmdline_parse_inst_t *)&cmd_set_port_tm_node_parent,
>>  	(cmdline_parse_inst_t *)&cmd_port_tm_hierarchy_commit,
>>  	(cmdline_parse_inst_t *)&cmd_cfg_tunnel_udp_port,
>> +	(cmdline_parse_inst_t *)&cmd_operate_bpf_ld_parse,
>> +	(cmdline_parse_inst_t *)&cmd_operate_bpf_unld_parse,
> 
> It can be better to move testpmd_funcs.rst updates in doc patch into this patch,
> it helps confirming the both doc and patch.
>