From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radu Nicolau Subject: Re: [PATCH] examples/l3fw-power: do not exit on power lib init failure Date: Fri, 27 Jul 2018 10:56:40 +0100 Message-ID: <76f02afd-a7b3-7f7f-3772-badd050cb6ee@intel.com> References: <1531921784-10578-1-git-send-email-radu.nicolau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "Hunt, David" , "Yao, Lei A" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0C80E37A2 for ; Fri, 27 Jul 2018 11:56:43 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/26/2018 6:39 PM, De Lara Guarch, Pablo wrote: > Hi Radu, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Radu Nicolau >> Sent: Wednesday, July 18, 2018 2:50 PM >> To: dev@dpdk.org >> Cc: Hunt, David ; Yao, Lei A ; >> Nicolau, Radu >> Subject: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init >> failure >> >> Do not exit the application if power library fails to initialize or high performance >> cores configuration cannot be used. > I would say this deserves more explanation. It doesn't look correct to me to keep log an error that > the power library couldn't be initialized and still the sample application keeps running. The application can also be used without the power library features, and this was also the previous behavior, before high/regular performance core feature was added. > > Actually, the way init_power_library is coded, it returns the output of the call of rte_power_init on the last core > (ret is overwritten for each core), which looks wrong to me. I will update init_power_library to return -1 if rte_power_init fails for at least one core. > > Thanks, > Pablo >> Signed-off-by: Radu Nicolau >> ---