From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <rjarry@redhat.com>, <mb@smartsharesystems.com>,
<maxime@leroys.fr>, <konstantin.ananyev@huawei.com>,
<stable@dpdk.org>
Subject: Re: [RFC PATCH v2 3/7] app/test-fib: fix size of the tables for large counts
Date: Thu, 15 Oct 2026 15:21:32 +0100 [thread overview]
Message-ID: <7706c795-6915-4db0-ad45-9031471e72c5@intel.com> (raw)
In-Reply-To: <20261014155227.0ed1cf10@phoenix.local>
Hi Stephen,
On 10/14/2026 11:52 PM, Stephen Hemminger wrote:
> On Wed, 14 Oct 2026 18:39:17 +0000
> Vladimir Medvedkin <vladimir.medvedkin@intel.com> wrote:
>
>> diff --git a/app/test-fib/main.c b/app/test-fib/main.c
>> index d85d94fdd1..0bc8dd2aa4 100644
>> --- a/app/test-fib/main.c
>> +++ b/app/test-fib/main.c
>> @@ -1260,12 +1260,12 @@ main(int argc, char **argv)
>> BURST_SZ);
>>
>> /* Alloc routes table*/
>> - config.rt = rte_malloc(NULL, rt_ent_sz * config.nb_routes, 0);
>> + config.rt = rte_malloc(NULL, (size_t)rt_ent_sz * config.nb_routes, 0);
>> if (config.rt == NULL)
>> rte_exit(-ENOMEM, "Can not alloc rt\n");
>>
>> /* Alloc table with ip's for lookup*/
>> - config.lookup_tbl = rte_malloc(NULL, lookup_ent_sz *
>> + config.lookup_tbl = rte_malloc(NULL, (size_t)lookup_ent_sz *
>> config.nb_lookup_ips, 0);
> if you are going to change these, then fix a couple related things.
> - comments have bad spacing in there
> - use rte_calloc() for arrays
will change
> - not sure why rte_malloc is used at all, this is test code. Doesn't need to be hugepages.
disagree. This array contains hundred millions of IP addresses and
occupies hundreds Mb. Also this array is used in performance benchmark.
I don't want to hit DTLB misses in performance tests.
--
Regards,
Vladimir
next prev parent reply other threads:[~2026-10-15 14:21 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 15:42 [RFC PATCH 0/4] VRF support in FIB library Vladimir Medvedkin
2026-03-22 15:42 ` [RFC PATCH 1/4] fib: add multi-VRF support Vladimir Medvedkin
2026-03-23 15:48 ` Konstantin Ananyev
2026-03-23 19:06 ` Medvedkin, Vladimir
2026-03-23 22:22 ` Konstantin Ananyev
2026-03-25 14:09 ` Medvedkin, Vladimir
2026-03-26 10:13 ` Konstantin Ananyev
2026-03-27 18:32 ` Medvedkin, Vladimir
2026-03-22 15:42 ` [RFC PATCH 2/4] fib: add VRF functional and unit tests Vladimir Medvedkin
2026-03-22 16:40 ` Stephen Hemminger
2026-03-22 16:41 ` Stephen Hemminger
2026-03-22 15:42 ` [RFC PATCH 3/4] fib6: add multi-VRF support Vladimir Medvedkin
2026-03-22 15:42 ` [RFC PATCH 4/4] fib6: add VRF functional and unit tests Vladimir Medvedkin
2026-03-22 16:45 ` Stephen Hemminger
2026-03-22 16:43 ` [RFC PATCH 0/4] VRF support in FIB library Stephen Hemminger
2026-03-23 9:01 ` Morten Brørup
2026-03-23 11:32 ` Medvedkin, Vladimir
2026-03-23 11:16 ` Medvedkin, Vladimir
2026-03-23 9:54 ` Robin Jarry
2026-03-23 11:34 ` Medvedkin, Vladimir
2026-03-23 11:27 ` Maxime Leroy
2026-03-23 12:49 ` Medvedkin, Vladimir
2026-03-23 14:53 ` Maxime Leroy
2026-03-23 15:08 ` Robin Jarry
2026-03-23 15:27 ` Morten Brørup
2026-03-23 18:52 ` Medvedkin, Vladimir
2026-03-23 18:42 ` Medvedkin, Vladimir
2026-03-24 9:19 ` Maxime Leroy
2026-03-25 15:56 ` Medvedkin, Vladimir
2026-03-25 21:43 ` Maxime Leroy
2026-03-27 18:27 ` Medvedkin, Vladimir
2026-04-02 16:51 ` Maxime Leroy
2026-03-23 19:05 ` Stephen Hemminger
2026-10-14 18:39 ` [RFC PATCH v2 0/7] " Vladimir Medvedkin
2026-10-14 18:39 ` [RFC PATCH v2 1/7] fib: fix return value of a nexthop update Vladimir Medvedkin
2026-10-14 18:39 ` [RFC PATCH v2 2/7] app/test-fib: fix lookup of the last burst Vladimir Medvedkin
2026-10-14 18:39 ` [RFC PATCH v2 3/7] app/test-fib: fix size of the tables for large counts Vladimir Medvedkin
2026-10-14 22:52 ` Stephen Hemminger
2026-10-15 14:21 ` Medvedkin, Vladimir [this message]
2026-10-14 18:39 ` [RFC PATCH v2 4/7] fib: add DIR8-16-8 algorithm Vladimir Medvedkin
2026-10-14 18:39 ` [RFC PATCH v2 5/7] fib: add multi-VRF support Vladimir Medvedkin
2026-10-14 18:39 ` [RFC PATCH v2 6/7] fib: split DIR24-8 table update from the FIB wrapper Vladimir Medvedkin
2026-10-14 18:39 ` [RFC PATCH v2 7/7] fib: add hash based VRF support for DIR24-8 Vladimir Medvedkin
2026-10-14 22:55 ` [RFC PATCH v2 0/7] VRF support in FIB library Stephen Hemminger
2026-10-15 14:17 ` Medvedkin, Vladimir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7706c795-6915-4db0-ad45-9031471e72c5@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=maxime@leroys.fr \
--cc=mb@smartsharesystems.com \
--cc=rjarry@redhat.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox