From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] mk: crypto pmds can only be built if
	librte_cryptodev is enabled
Date: Fri, 11 Mar 2016 10:28:10 +0100
Message-ID: <7728480.8SZanX4UKp@xps13>
References: <9127451bf67ce08532a327cb66aefbcf7ed5b39f.1457687628.git.pmatilai@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Panu Matilainen <pmatilai@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 770492BDB
 for <dev@dpdk.org>; Fri, 11 Mar 2016 10:29:53 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id p65so9537366wmp.0
 for <dev@dpdk.org>; Fri, 11 Mar 2016 01:29:53 -0800 (PST)
In-Reply-To: <9127451bf67ce08532a327cb66aefbcf7ed5b39f.1457687628.git.pmatilai@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-11 11:13, Panu Matilainen:
> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
> build of any crypto pmds will fail because of the missing dependency.
> This has been present for a while now but hidden until the addition
> of null_crypto since all the other crypto pmds have been disabled
> by default.

Good catch, thanks.

> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
>  DIRS-y += crypto
> +endif

Why not 
DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto ?