From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 1/1] ip_pipeline: fix null pointer dereference
Date: Tue, 14 Jun 2016 21:10:52 +0200
Message-ID: <7742479.vO64Iz13lh@xps13>
References: <1465810549-19097-1-git-send-email-marcinx.kerlin@intel.com>
 <3EB4FA525960D640B5BDFFD6A3D8912647A0255F@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
 "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
To: "Kerlin, MarcinX" <marcinx.kerlin@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 0D7A49ABF
 for <dev@dpdk.org>; Tue, 14 Jun 2016 21:10:54 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id k204so4525301wmk.0
 for <dev@dpdk.org>; Tue, 14 Jun 2016 12:10:54 -0700 (PDT)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A0255F@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > Return value of function app_pipeline_type_find is not checking before
> > dereference. Fix this problem by adding checking condition.
> > 
> > Coverity issue: 127196
> > Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread binding
> > dynamically")
> > 
> > Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>

> Hi Marcin,
> 
> Checking p_type at this point is not required, as we already validated the pipeline settings (including the pipeline type) as part of the init code.
> 
> But since this code is harmless I am acking this patch just to avoid having the same discussion about this Coverity false positive issue again.
> 
> Regards,
> Cristian
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks