From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] crypto/dpaa2_sec: fix build with GCC 6 or prior Date: Tue, 30 Jan 2018 15:01:07 +0100 Message-ID: <7749257.NxZygTFbjZ@xps> References: <1517304210-15061-1-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Hemant Agrawal Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 43E121B3E0 for ; Tue, 30 Jan 2018 15:01:54 +0100 (CET) In-Reply-To: <1517304210-15061-1-git-send-email-hemant.agrawal@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/01/2018 10:23, Hemant Agrawal: > This patch fixes the compilation with compiler GCC < 7 >=20 > dpaa2_sec/hw/rta/operation_cmd.h:12:32: error: unknown option after > =E2=80=98#pragma GCC diagnostic=E2=80=99 kind [-Werror=3Dpragmas] > #pragma GCC diagnostic ignored "-Wimplicit-fallthrough" >=20 > Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7") Sorry for having broken it with a quick fix yesterday. > Signed-off-by: Hemant Agrawal [...] > +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION > 70000) > #pragma GCC diagnostic ignored "-Wimplicit-fallthrough" > +#endif I think it must be GCC_VERSION >=3D 70000 Applied with this change, thanks