From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control Date: Wed, 12 Nov 2014 10:30:39 +0100 Message-ID: <7782514.0Lq6O9Rqxb@xps13> References: <1413180766-12211-1-git-send-email-helin.zhang@intel.com> <1639194.lo0Mfvn8hI@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Zhang, Helin" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-11-12 05:52, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > Actually you use ETH_FLOW_TYPE_IPV4 for ixgbe and > > ETH_FLOW_TYPE_FRAG_IPV4 or ETH_FLOW_TYPE_NONFRAG_IPV4_* for i40e. > > It's not consistent and clearly shows that you stick to the hardware definitions. > > > > Something really generic could be a set of flags like this: > > IPV4 > > IPV6 > > NONFRAG > > UDP > > TCP > > SCTP > > Good conclusion! We could think of it in a new patch set. > I don't want to put everything into this patch. :) If you agree flags must be used, the old defines must be removed. So no need to rename the defines. I think you should directly change to flags (in this patchset or another). Thanks -- Thomas