From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH] igb_uio: remove out-of-date comment
Date: Tue, 15 Jan 2019 16:08:49 +0000
Message-ID: <77b04e1c-e4e1-1b34-910e-c1655b8d0f8e@intel.com>
References: <20190115154626.34516-1-xiaolong.ye@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Xiaolong Ye <xiaolong.ye@intel.com>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id A78D02B95
 for <dev@dpdk.org>; Tue, 15 Jan 2019 17:08:52 +0100 (CET)
In-Reply-To: <20190115154626.34516-1-xiaolong.ye@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 15-Jan-19 3:46 PM, Xiaolong Ye wrote:
> The comment for igbuio_pci_irqhandler is out of date as the code evolves,
> remove it to avoid misleading.
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>   kernel/linux/igb_uio/igb_uio.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c
> index 3cf394bdf..7e69b4498 100644
> --- a/kernel/linux/igb_uio/igb_uio.c
> +++ b/kernel/linux/igb_uio/igb_uio.c
> @@ -185,11 +185,6 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state)
>   	return 0;
>   }
>   
> -/**
> - * This is interrupt handler which will check if the interrupt is for the right device.
> - * If yes, disable it here and will be enable later.
> - */
> -static irqreturn_t
>   igbuio_pci_irqhandler(int irq, void *dev_id)
>   {
>   	struct rte_uio_pci_dev *udev = (struct rte_uio_pci_dev *)dev_id;
> 

I think you removed one extra line there...

-- 
Thanks,
Anatoly