From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH] net/virtio-user: fix dev_init in legacy-mem
	mode
Date: Thu, 17 May 2018 10:03:23 +0200
Message-ID: <77d27fbb-710a-3b4b-43e7-30776529c83e@redhat.com>
References: <20180517073525.103984-1-xiao.w.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, tiwei.bie@intel.com, lei.a.yao@intel.com
To: Xiao Wang <xiao.w.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 439264C8C
 for <dev@dpdk.org>; Thu, 17 May 2018 10:03:27 +0200 (CEST)
In-Reply-To: <20180517073525.103984-1-xiao.w.wang@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Xiao,

Next time, could you please devtools/check-git-log.sh script before
posting.

I tihnk the commit title should be changed to:
net/virtio-user: fix device init in legacy-mem mode

On 05/17/2018 09:35 AM, Xiao Wang wrote:
> In legacy-mem mode, memory event callback registering is not supported,
> we should not return error in dev_init on this case.
> 
> Fixes: 12ecb2f63b12 ("net/virtio-user: support memory hotplug")
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> Suggested-by: Tiwei Bie <tiwei.bie@intel.com>

I think the suggested-by line should go above the signed-off one,
as it was suggested before being implemented.

> ---
>   drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index 992a68757..bd16fbb60 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -445,8 +445,11 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
>   
>   	if (rte_mem_event_callback_register(VIRTIO_USER_MEM_EVENT_CLB_NAME,
>   				virtio_user_mem_event_cb, dev)) {
> -		PMD_INIT_LOG(ERR, "Failed to register mem event callback\n");
> -		return -1;
> +		if (rte_errno != ENOTSUP) {
> +			PMD_INIT_LOG(ERR, "Failed to register mem event"
> +					" callback\n");
> +			return -1;
> +		}
>   	}
>   
>   	return 0;
> 

Apart above minor comments, the patch looks good to me:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I'll handle the changes when applying.

Thanks,
Maxime