From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v14 5/6] drivers/net: enable device detach on
 secondary
Date: Sun, 12 Aug 2018 13:50:45 +0300
Message-ID: <780aace9-e241-b81f-dc98-5200be5ecaeb@solarflare.com>
References: <20180607123849.14439-1-qi.z.zhang@intel.com>
 <20180810004213.44497-1-qi.z.zhang@intel.com>
 <20180810004213.44497-6-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <konstantin.ananyev@intel.com>, <dev@dpdk.org>,
 <bruce.richardson@intel.com>, <ferruh.yigit@intel.com>,
 <benjamin.h.shelton@intel.com>, <narender.vangati@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>, <thomas@monjalon.net>,
 <gaetan.rivet@6wind.com>, <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 8C2A72BC8
 for <dev@dpdk.org>; Sun, 12 Aug 2018 12:51:02 +0200 (CEST)
In-Reply-To: <20180810004213.44497-6-qi.z.zhang@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10.08.2018 03:42, Qi Zhang wrote:
> With the enabling for hotplug on multi-process, it is not necessary
> to prevent detaching a device from a secondary process.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

 From the patch itself including description it is absolutely unclear
why detach works and where it actually happens.
Why is it OK to return 0 instead of error and that's it.
Why is it necessary to call uninit at all in the case of secondary
processes?