From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: fix rte_errno values for IPC API Date: Tue, 13 Feb 2018 14:50:52 +0100 Message-ID: <7815253.RbYmxIpbrz@xps> References: <46a01b34318bbc799a0911fbb166a592c34ffa66.1518267551.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Tan, Jianfeng" To: "Burakov, Anatoly" Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C02481B2EF for ; Tue, 13 Feb 2018 14:51:02 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > rte_errno values should not be negative. > > > > Fixes: bacaa2754017 ("eal: add channel for multi-process communication") > > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > > Cc: jianfeng.tan@intel.com > > Signed-off-by: Anatoly Burakov > > Reviewed-by: Jianfeng Tan > > Thanks for fixing this. Applied, thanks There are a lot of similar issues: git grep -l 'rte_errno = -E' | sed 's,[^/]*$,,' | sort -u drivers/event/opdl/ drivers/event/sw/ drivers/net/avf/ drivers/net/e1000/ drivers/net/ena/ drivers/net/enic/ drivers/net/fm10k/ drivers/net/i40e/ drivers/net/ixgbe/ drivers/net/qede/ drivers/net/vmxnet3/ examples/ipsec-secgw/ lib/librte_ether/ lib/librte_eventdev/