From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal/ppc64: revert implement arch-specific
	TSC freq query
Date: Wed, 07 Feb 2018 08:26:04 +0100
Message-ID: <7852603.J7xFuoqAEp@xps>
References: <ff8e2632bd2ea1857d67d8b6f39410d69b701f21.1517302663.git.gowrishankar.m@linux.vnet.ibm.com>
 <3728847.cnur1V9eyL@xps> <000901d39fe1$fcdfcde0$f69f69a0$@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: 'Gowrishankar' <gowrishankar.m@linux.vnet.ibm.com>, dev@dpdk.org
To: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 065371B796
 for <dev@dpdk.org>; Wed,  7 Feb 2018 08:26:09 +0100 (CET)
In-Reply-To: <000901d39fe1$fcdfcde0$f69f69a0$@linux.vnet.ibm.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

07/02/2018 08:05, Chao Zhu:
> The previous patch has some misunderstanding of the the TSC frequency
> counting.
> I support this.

Chao, it is very late in the release cycle.
Do you want to take the risk of applying this patch in 18.02-rc4?
If you discover a bug in this patch next week, it will be too late
for fixing it in 18.02.


> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: 2018=E5=B9=B42=E6=9C=881=E6=97=A5 8:30
> > To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>; Chao Zhu
> > <chaozhu@linux.vnet.ibm.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement arch-specif=
ic
> TSC
> > freq query
> >=20
> > 30/01/2018 09:59, Gowrishankar:
> > > From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> > >
> > > This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3
> > > (eal/ppc64: implement arch-specific TSC freq query). We intended to
> > > derive pkt/sec estimation with cpu clock frequency. As timebase
> > > register serves the timer purpose, we need to stick with it for
> > > calculating pkt/sec, hence reverting the change.
> > >
> > > Fixes: 15692396fd (eal/ppc64: implement arch-specific TSC freq query)
> >=20
> > It is not clear what it is fixing.
> >=20
> > Chao, please review.
>=20
>=20