From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCHv4 1/4] rte_compat.h : Clean up some typos
Date: Wed, 08 Jul 2015 11:52:51 +0200
Message-ID: <7897190.qLvkiMcu3A@xps13>
References: <1435088014-18973-1-git-send-email-nhorman@tuxdriver.com>
 <1435586380-1673-1-git-send-email-nhorman@tuxdriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Neil Horman <nhorman@tuxdriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com
 [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id AA2BD5A44
 for <dev@dpdk.org>; Wed,  8 Jul 2015 11:54:01 +0200 (CEST)
Received: by wibdq8 with SMTP id dq8so207282903wib.1
 for <dev@dpdk.org>; Wed, 08 Jul 2015 02:54:01 -0700 (PDT)
In-Reply-To: <1435586380-1673-1-git-send-email-nhorman@tuxdriver.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Neil,

2015-06-29 09:59, Neil Horman:
> - *	int __vsym foo_v20(char *string)
> + *	int foo_v20(char *string)
[...]
> -#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) RTE_STR(e) ", "RTE_STR(b)"@@DPDK_"RTE_STR(n))
> +#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) RTE_STR(e) ", " RTE_STR(b) "@@DPDK_" RTE_STR(n))
>  #define __vsym __attribute__((used))

In this patch, you removed __vsym from the example but the #define still exists.
Should it be removed? or documented?

Thanks