From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v5 2/3] ethdev: introduce Tx queue offloads API Date: Tue, 3 Oct 2017 20:50:29 +0100 Message-ID: <78b481de-8247-d549-fb08-f90e310b12ab@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: arybchenko@solarflare.com, konstantin.ananyev@intel.com, jerin.jacob@caviumnetworks.com, dev@dpdk.org To: Shahaf Shuler , thomas@monjalon.net Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 66B011B5DB for ; Tue, 3 Oct 2017 21:50:37 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/28/2017 7:54 PM, Shahaf Shuler wrote: > Introduce a new API to configure Tx offloads. > > In the new API, offloads are divided into per-port and per-queue > offloads. The PMD reports capability for each of them. > Offloads are enabled using the existing DEV_TX_OFFLOAD_* flags. > To enable per-port offload, the offload should be set on both device > configuration and queue configuration. To enable per-queue offload, the > offloads can be set only on queue configuration. > > In addition the Tx offloads will be disabled by default and be > enabled per application needs. This will much simplify PMD management of > the different offloads. > > Applications should set the ETH_TXQ_FLAGS_IGNORE flag on txq_flags > field in order to move to the new API. > > The old Tx offloads API is kept for the meanwhile, in order to enable a > smooth transition for PMDs and application to the new API. > > Signed-off-by: Shahaf Shuler <...> > @@ -620,6 +628,15 @@ Supports packet type parsing and returns a list of supported types. > > .. _nic_features_timesync: > > +Mbuf fast free > +-------------- I think this is not one of the current tracked features. Is this coming/planed with new patches? I suggest removing from this patch, and if required add with another patch that both updates default.ini and this documented. > + > +Supports optimization for fast release of mbufs following successful Tx. > +Requires all mbufs to come from the same mempool and has refcnt = 1. > + > +* **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_MBUF_FAST_FREE``. > +* **[provides] rte_eth_dev_info**: ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_MBUF_FAST_FREE``. > + > Timesync > -------- > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index 9b73d2377..59756dd82 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c <...>