From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 2/2] doc: update testpmd user guide for
 the heavyweight mode GRO
Date: Mon, 21 Aug 2017 12:03:37 +0100
Message-ID: <78ba62e4-5917-3ec8-91f9-e9937ba556b7@intel.com>
References: <1502333448-75976-1-git-send-email-jiayu.hu@intel.com>
 <1502960892-112960-1-git-send-email-jiayu.hu@intel.com>
 <1502960892-112960-3-git-send-email-jiayu.hu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: konstantin.ananyev@intel.com, jianfeng.tan@intel.com,
 thomas@monjalon.net, jingjing.wu@intel.com, lei.a.yao@intel.com
To: Jiayu Hu <jiayu.hu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 9F7DC7CDF
 for <dev@dpdk.org>; Mon, 21 Aug 2017 13:03:42 +0200 (CEST)
In-Reply-To: <1502960892-112960-3-git-send-email-jiayu.hu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/17/2017 10:08 AM, Jiayu Hu wrote:
> This patch is to update testpmd user guide for the heavyweight mode GRO.

Documentation can be part of the implementation patch.
It is good to split patches logically, but I don't see the benefit of
splitting patch as documentation and implementation.

> 
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> ---

<...>

>  
> +set gro flush interval
> +~~~~~~~~~~~~~~~~~~~~~~
> +
> +Set the interval of flushing GROed packets from reassembly tables::
> +
> +   testpmd> set gro flush interval (num)
> +
> +In the heavyweight mode, GROed packets are stored in reassembly tables
> +and need flushing from the tables manually. This command is to set the
> +number of performing GRO operations between two flushing operations.
> +
> +The value of ``num`` should be in the range of 0 to ``GRO_MAX_FLUSH_INTERVAL``.
> +``0`` means flush GROed packets from the tables when one GRO operation
> +finishes.

It can be good to mention default interval value is
GRO_DEFAULT_FLUSH_INTERVAL if this command not issued.

> +
>  mac_addr add
>  ~~~~~~~~~~~~
>  
>