DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Renyong Wan" <wanry@yunsilicon.com>
To: "David Marchand" <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, "Gaetan Rivet" <grive@u256.net>,
	 "Rosen Xu" <rosen.xu@altera.com>,
	 "Dimon Zhao" <dimon.zhao@nebula-matrix.com>,
	 "Leon Yu" <leon.yu@nebula-matrix.com>,
	 "Sam Chen" <sam.chen@nebula-matrix.com>,
	"Wei Hu" <weh@microsoft.com>,
	 "Praveen Shetty" <praveen.shetty@intel.com>,
	 "Jingjing Wu" <jingjing.wu@intel.com>,
	"Na Na" <nana@yunsilicon.com>,
	 "Rong Qian" <qianr@yunsilicon.com>,
	 "Xiaoxiong Zhang" <zhangxx@yunsilicon.com>,
	 "Dongwei Xu" <xudw@yunsilicon.com>,
	"Andy Pei" <andy.pei@intel.com>,  "Dan Wei" <dan.wei@intel.com>,
	"Junfeng Guo" <junfengg@nvidia.com>,
	 "Beilei Xing" <beilei.xing@intel.com>,
	 "Xiaoyun Li" <xiaoyun.li@intel.com>,
	"Mingxia Liu" <mingxia.liu@intel.com>
Subject: Re: [PATCH v2 10/12] drivers/net: fix reported RSS capability
Date: Thu, 22 Oct 2026 14:17:47 +0800	[thread overview]
Message-ID: <79cd25f4-593a-4e66-b3ac-0a08ce258744@yunsilicon.com> (raw)
In-Reply-To: <20261021103027.2050351-11-david.marchand@redhat.com>

On 10/21/2026 6:30 PM, David Marchand wrote:
> Some drivers (idpf, cpfl) report RSS support even if lacking HW support.
> On the other hand, some driver do have support but do not advertise it
> (either in dev_info, or in the documentation).
> 
> failsafe may support RSS, as it only passes the requests to the ports
> attached to it, hence mark it as partial support.
> 
> Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
> Fixes: 70675bcc3a57 ("net/idpf: support RSS")
> Fixes: cfbc66551a14 ("net/cpfl: support RSS")
> Fixes: 5fb899f4b225 ("net/xsc: support RSS configuration")
> Fixes: 9f75cad1287f ("net/xsc: add PCT interfaces")
> Fixes: ff8db3711b29 ("net/nbl: support infos query")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v1:
> - fixed ip3nke,
> - moved all RSS capabilities under check for idpf and cpfl,
> - adjusted xsc RSS capabilities,
> 
> ---
>   doc/guides/nics/features/failsafe.ini     | 1 +
>   doc/guides/nics/features/ipn3ke.ini       | 3 ---
>   doc/guides/nics/features/nbl.ini          | 1 +
>   doc/guides/nics/features/netvsc.ini       | 1 +
>   drivers/net/intel/cpfl/cpfl_ethdev.c      | 9 +++++----
>   drivers/net/intel/cpfl/cpfl_representor.c | 4 +++-
>   drivers/net/intel/idpf/idpf_ethdev.c      | 9 +++++----
>   drivers/net/xsc/xsc_ethdev.c              | 4 ++++
>   8 files changed, 20 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c
> index 5fbe68782e..20d6f58f68 100644
> --- a/drivers/net/xsc/xsc_ethdev.c
> +++ b/drivers/net/xsc/xsc_ethdev.c
> @@ -469,6 +469,10 @@ xsc_ethdev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)
>   	info->if_index = priv->ifindex;
>   	info->speed_capa = priv->xdev->link_speed_capa;
>   	info->hash_key_size = XSC_RSS_HASH_KEY_LEN;
> +	info->flow_type_rss_offloads = RTE_ETH_RSS_IP | RTE_ETH_RSS_UDP |
> +		RTE_ETH_RSS_TCP | RTE_ETH_RSS_L3_SRC_ONLY |
> +		RTE_ETH_RSS_L3_DST_ONLY | RTE_ETH_RSS_L4_SRC_ONLY |
> +		RTE_ETH_RSS_L4_DST_ONLY | RTE_ETH_RSS_LEVEL_INNERMOST;
>   	info->tx_desc_lim.nb_seg_max = 8;
>   	info->tx_desc_lim.nb_mtu_seg_max = 8;
>   	info->switch_info.name = dev->data->name;

Looks good for net/xsc,

Reviewed-by: Renyong Wan <wanry@yunsilicon.com>

Thanks,
Renyong Wan

  reply	other threads:[~2026-10-22  6:18 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 13:05 [PATCH 0/8] Validate multiqueue configuration in ethdev David Marchand
2026-10-16 13:05 ` [PATCH 1/8] net/bnxt: remove leftover VMDq code in MAC helpers David Marchand
2026-10-16 13:05 ` [PATCH 2/8] drivers/net: fix reported VMDq capability David Marchand
2026-10-16 13:05 ` [PATCH 3/8] drivers/net: remove check on VMDq modes David Marchand
2026-10-16 13:05 ` [PATCH 4/8] devtools: check VMDq capability David Marchand
2026-10-16 13:05 ` [PATCH 5/8] ethdev: check DCB availability David Marchand
2026-10-16 13:05 ` [PATCH 6/8] drivers/net: fix reported RSS capability David Marchand
2026-10-16 13:05 ` [PATCH 7/8] ethdev: check RSS availability David Marchand
2026-10-16 13:05 ` [PATCH 8/8] ethdev: check unknown Rx/Tx multi-queue modes David Marchand
2026-10-16 16:44 ` [PATCH 0/8] Validate multiqueue configuration in ethdev Stephen Hemminger
2026-10-19  6:41   ` Renyong Wan
2026-10-21 10:30 ` [PATCH v2 00/12] " David Marchand
2026-10-21 10:30   ` [PATCH v2 01/12] devtools: fix matching in doc check David Marchand
2026-10-21 10:42     ` Thomas Monjalon
2026-10-21 10:30   ` [PATCH v2 02/12] doc: fix L2TPv2 and PPP matching support for ICE David Marchand
2026-10-21 10:30   ` [PATCH v2 03/12] devtools: handle multiple drivers in doc check David Marchand
2026-10-22  9:39     ` Thomas Monjalon
2026-10-21 10:30   ` [PATCH v2 04/12] net/bnxt: remove leftover VMDq code in MAC helpers David Marchand
2026-10-21 10:30   ` [PATCH v2 05/12] drivers/net: fix reported VMDq capability David Marchand
2026-10-21 10:53     ` Bruce Richardson
2026-10-21 10:30   ` [PATCH v2 06/12] drivers/net: remove check on VMDq modes David Marchand
2026-10-21 10:55     ` Bruce Richardson
2026-10-21 10:30   ` [PATCH v2 07/12] devtools: check VMDq capability David Marchand
2026-10-22  9:44     ` Thomas Monjalon
2026-10-21 10:30   ` [PATCH v2 08/12] doc: fix DCB capability for some Intel drivers David Marchand
2026-10-21 11:04     ` Bruce Richardson
2026-10-21 10:30   ` [PATCH v2 09/12] ethdev: check DCB availability David Marchand
2026-10-21 11:07     ` Bruce Richardson
2026-10-21 10:30   ` [PATCH v2 10/12] drivers/net: fix reported RSS capability David Marchand
2026-10-22  6:17     ` Renyong Wan [this message]
2026-10-21 10:30   ` [PATCH v2 11/12] ethdev: check RSS availability David Marchand
2026-10-21 10:30   ` [PATCH v2 12/12] ethdev: check unknown Rx/Tx multi-queue modes David Marchand
2026-10-21 17:42   ` [PATCH v2 00/12] Validate multiqueue configuration in ethdev Stephen Hemminger
2026-10-22 17:44 ` [PATCH v3 00/13] " David Marchand
2026-10-22 17:44   ` [PATCH v3 01/13] devtools: fix matching in doc check David Marchand
2026-10-22 17:44   ` [PATCH v3 02/13] doc: fix L2TPv2 and PPP matching support for ICE David Marchand
2026-10-22 17:44   ` [PATCH v3 03/13] devtools: support Intel drivers in doc check David Marchand
2026-10-23 10:11     ` Thomas Monjalon
2026-10-22 17:44   ` [PATCH v3 04/13] devtools: handle multiple " David Marchand
2026-10-23 10:13     ` Thomas Monjalon
2026-10-23 15:08       ` David Marchand
2026-10-22 17:44   ` [PATCH v3 05/13] net/bnxt: remove leftover VMDq code in MAC helpers David Marchand
2026-10-22 17:44   ` [PATCH v3 06/13] drivers/net: fix reported VMDq capability David Marchand
2026-10-22 17:44   ` [PATCH v3 07/13] drivers/net: remove check on VMDq modes David Marchand
2026-10-27  2:38     ` fengchengwen
2026-10-22 17:44   ` [PATCH v3 08/13] devtools: check VMDq capability David Marchand
2026-10-22 17:44   ` [PATCH v3 09/13] doc: fix DCB capability for some Intel drivers David Marchand
2026-10-22 17:44   ` [PATCH v3 10/13] ethdev: check DCB availability David Marchand
2026-10-27  2:39     ` fengchengwen
2026-10-22 17:44   ` [PATCH v3 11/13] drivers/net: fix reported RSS capability David Marchand
2026-10-22 17:44   ` [PATCH v3 12/13] ethdev: check RSS availability David Marchand
2026-10-27  2:41     ` fengchengwen
2026-10-22 17:44   ` [PATCH v3 13/13] ethdev: check unknown Rx/Tx multi-queue modes David Marchand
2026-10-26 18:11   ` [PATCH v3 00/13] Validate multiqueue configuration in ethdev Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79cd25f4-593a-4e66-b3ac-0a08ce258744@yunsilicon.com \
    --to=wanry@yunsilicon.com \
    --cc=andy.pei@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dan.wei@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dimon.zhao@nebula-matrix.com \
    --cc=grive@u256.net \
    --cc=jingjing.wu@intel.com \
    --cc=junfengg@nvidia.com \
    --cc=leon.yu@nebula-matrix.com \
    --cc=mingxia.liu@intel.com \
    --cc=nana@yunsilicon.com \
    --cc=praveen.shetty@intel.com \
    --cc=qianr@yunsilicon.com \
    --cc=rosen.xu@altera.com \
    --cc=sam.chen@nebula-matrix.com \
    --cc=thomas@monjalon.net \
    --cc=weh@microsoft.com \
    --cc=xiaoyun.li@intel.com \
    --cc=xudw@yunsilicon.com \
    --cc=zhangxx@yunsilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox