From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure
 with zero RX/TX queues
Date: Thu, 20 Dec 2018 23:34:42 +0000
Message-ID: <79d212a9-7205-3852-3d06-650e9e7ab65b@intel.com>
References: <20160516113349.7d2a992f@miho> <1881092.YNl14ETpPN@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 1A11D1BDAA
 for <dev@dpdk.org>; Fri, 21 Dec 2018 00:34:44 +0100 (CET)
In-Reply-To: <1881092.YNl14ETpPN@xps13>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/23/2016 4:53 PM, thomas.monjalon at 6wind.com (Thomas Monjalon) wrote:
> 2016-05-16 11:33, Simon Kagstrom:
>> This allows releasing RX/TX queue memory.
>> ---
>> We're using DPDK 16.04 and have a test suite which performs a sequence
>> of separate tests of the type
>>
>>    allocate mempool
>>    rte_eth_dev_configure(port, n_rxq, n_txq, ...)
>>    setup rx/tx queues
>>    rte_eth_dev_start(port)
>>
>>    <perform actual test>
>>
>>    stop rx/tx queues
>>    rte_eth_dev_stop(port)
>>
>> -> rte_eth_dev_configure(port, 0, 0, ...)
>>    
>>    check that there are no leaks from the mempool
>>
>> The crucial point is the marked line above. This is done so that the
>> rx_queue_release/tx_queue_release callbacks in the PMD is called, so
>> that mbufs allocated by the driver is released.
> 
> I think you are trying to use a side effect of rte_eth_dev_configure().
> After calling rte_eth_dev_stop(), I would say the clean-up should be done
> by rte_eth_dev_close().
> Why not using close?
> 

Hi Simon,

This patch is in patchwork for a long time without response, updating its status
as rejected, if it is still relevant please let us know.