From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2] examples/l3fwd: fix NEON instructions Date: Tue, 7 Nov 2017 00:05:00 -0800 Message-ID: <79e54de9-f542-a624-e55f-e43ba7d8a019@intel.com> References: <20171030073126.1662-1-gprathyusha@caviumnetworks.com> <20171030073614.GA27106@arm.com> <20171102103342.GA20462@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Guduri Prathyusha , tomasz.kantecki@intel.com, guduriprathyusha@gmail.com, dev@dpdk.org, thomas@monjalon.net To: Jerin Jacob , Jianbo Liu Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 41EE71B3D4 for ; Tue, 7 Nov 2017 09:05:02 +0100 (CET) In-Reply-To: <20171102103342.GA20462@jerin> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2017 3:33 AM, Jerin Jacob wrote: > -----Original Message----- >> Date: Mon, 30 Oct 2017 15:36:15 +0800 >> From: Jianbo Liu >> To: Guduri Prathyusha >> CC: tomasz.kantecki@intel.com, guduriprathyusha@gmail.com, dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions >> User-Agent: Mutt/1.5.21 (2010-09-15) >> >> The 10/30/2017 13:01, Guduri Prathyusha wrote: >>> To group consecutive packets with same destination port in bursts of 4 >>> neon intrinsic data types dp1 and dp2 are calculated such that if >>> dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: and >>> dp2 should contain: in the first iteration. dp1 should >>> be and dp2 should be in the next iteration. >>> >>> Whereas the existing code incorrectly calculates dp1 as from >>> second iteration. >>> >>> This patch fixes the incorrect ARM NEON instructions on dp1. >>> >>> Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation") >>> >>> Signed-off-by: Guduri Prathyusha >> >> Acked-by: Jianbo Liu > > Acked-by: Jerin Jacob Applied to dpdk/master, thanks.