From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: [PATCH] mbuf:using sanity checks do not panic on
 null mbuf
Date: Mon, 8 Jan 2018 15:41:12 +0000
Message-ID: <7C6B7ADB-6412-45F1-9BA0-84F1025FA473@intel.com>
References: <20180108153423.57648-1-keith.wiles@intel.com>
 <20180108073941.791cba4f@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id B382B1B1C8
 for <dev@dpdk.org>; Mon,  8 Jan 2018 16:41:19 +0100 (CET)
In-Reply-To: <20180108073941.791cba4f@xeon-e3>
Content-Language: en-US
Content-ID: <8EF328FBBEA9A4449570E078A4BB2525@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> On Jan 8, 2018, at 9:39 AM, Stephen Hemminger <stephen@networkplumber.org=
> wrote:
>=20
> On Mon,  8 Jan 2018 09:34:23 -0600
> Keith Wiles <keith.wiles@intel.com> wrote:
>=20
>> +	if (!m || !f) {
>> +		fprintf(stderr, "MBUF and/or FILE pointer is NULL\n");
>> +		return;
>> +	}
>=20
> Calling with f of NULL is user error, let it still die in fprintf.

I thought about that too, but this routine is a debug routine does it reall=
y matter?

Regards,
Keith