From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilya Matveychikov <matvejchikov@gmail.com>
Subject: Re: [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(),
 remove useless variable
Date: Wed, 15 Nov 2017 00:50:58 +0400
Message-ID: <7CC49471-2114-4742-8C66-2CF286DE2CF2@gmail.com>
References: <3DBFD712-8DA6-4FDB-B139-66398039B4C0@gmail.com>
 <c09a80d037c2438f9fb4dc5c012a4b4d@XCH-RTP-017.cisco.com>
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Hanoch Haim (hhaim)" <hhaim@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id D436B9FE
 for <dev@dpdk.org>; Tue, 14 Nov 2017 21:51:01 +0100 (CET)
Received: by mail-wm0-f43.google.com with SMTP id z3so24751534wme.5
 for <dev@dpdk.org>; Tue, 14 Nov 2017 12:51:01 -0800 (PST)
In-Reply-To: <c09a80d037c2438f9fb4dc5c012a4b4d@XCH-RTP-017.cisco.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On Nov 15, 2017, at 12:32 AM, Hanoch Haim (hhaim) <hhaim@cisco.com> wrote:
> 
> I would add this too 
> 
> -  } else if (rte_atomic16_add_return(&m->refcnt_atomic, -1) == 0)
> 
> Should be :
> 
> + } else if (likely(rte_mbuf_refcnt_update(m, -1) == 0)) {
> 
> 
> Hanoh
> 

Why not to send the separate patch for the change?