From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH] mem: warn user when running without NUMA
 support
Date: Wed, 27 Mar 2019 11:52:13 +0000
Message-ID: <7a0681ab-b71d-9a43-e4de-4827bed69ccc@intel.com>
References: <72f990b04219f319b2922570a7ca7b9ce93e0aae.1550851129.git.anatoly.burakov@intel.com>
 <10158735.WBPJjXTH6e@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, stable@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <10158735.WBPJjXTH6e@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 27-Mar-19 10:31 AM, Thomas Monjalon wrote:
> 22/02/2019 16:59, Anatoly Burakov:
>> Running in non-legacy mode on a NUMA-enabled system without libnuma
>> is unsupported, so explicitly print out a warning when trying to
>> do so.
>>
>> Running in legacy mode without libnuma is still supported whether or
>> not we are running with libnuma support enabled, so also fix init to
>> allow that scenario.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>> --- a/lib/librte_eal/linuxapp/eal/eal_memory.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
>> @@ -50,6 +50,7 @@
>>   #include "eal_internal_cfg.h"
>>   #include "eal_filesystem.h"
>>   #include "eal_hugepages.h"
>> +#include "eal_options.h"
> 
> I'm seeing this error:
> 
> lib/librte_eal/common/eal_options.h:74:28: error:
> array type has incomplete element type ‘struct option’
>   extern const struct option eal_long_options[];
> 

Yes, i've been meaning to resubmit but it fell through the cracks. I'll 
do a v2 ASAP.

-- 
Thanks,
Anatoly