From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] ethdev: replace bus specific struct with generic dev Date: Thu, 29 Mar 2018 10:20:25 +0100 Message-ID: <7a1cea48-0ce0-550b-fddb-4eaa2ef55ea8@intel.com> References: <20180327174052.266285-1-ferruh.yigit@intel.com> <20180329061723.GA31647@sh> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Tomasz Duszynski , dpdk-dev Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 48C762965 for ; Thu, 29 Mar 2018 11:20:28 +0200 (CEST) In-Reply-To: <20180329061723.GA31647@sh> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/29/2018 7:17 AM, Tomasz Duszynski wrote: > On Tue, Mar 27, 2018 at 06:40:52PM +0100, Ferruh Yigit wrote: >> Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it >> although it is common for all ethdev in all buses. >> >> Replacing pci specific struct with generic device struct and updating >> places that are using pci device in a way to get this information from >> generic device. >> >> Signed-off-by: Ferruh Yigit >> --- >> Cc: Pablo de Lara >> >> There is no deprecation notice sent for this update but in this release >> ethdev info already updated and ABI already broken, it can be good >> opportunity for this update. >> --- >> app/test-pmd/config.c | 11 ++++++++++- >> app/test-pmd/testpmd.h | 24 ++++++++++++++++++------ >> drivers/net/af_packet/rte_eth_af_packet.c | 1 + >> drivers/net/ark/ark_ethdev.c | 4 +++- >> drivers/net/avf/avf_ethdev.c | 2 +- >> drivers/net/avp/avp_ethdev.c | 2 +- >> drivers/net/bnx2x/bnx2x_ethdev.c | 2 +- >> drivers/net/bnxt/bnxt_ethdev.c | 2 +- >> drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- >> drivers/net/dpaa/dpaa_ethdev.c | 1 + >> drivers/net/dpaa2/dpaa2_ethdev.c | 1 + >> drivers/net/e1000/em_ethdev.c | 2 +- >> drivers/net/e1000/igb_ethdev.c | 4 ++-- >> drivers/net/ena/ena_ethdev.c | 2 +- >> drivers/net/enic/enic_ethdev.c | 2 +- >> drivers/net/fm10k/fm10k_ethdev.c | 2 +- >> drivers/net/i40e/i40e_ethdev.c | 2 +- >> drivers/net/i40e/i40e_ethdev_vf.c | 2 +- >> drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- >> drivers/net/kni/rte_eth_kni.c | 2 +- >> drivers/net/liquidio/lio_ethdev.c | 2 +- >> drivers/net/mlx4/mlx4_ethdev.c | 2 +- >> drivers/net/mlx5/mlx5_ethdev.c | 2 +- >> drivers/net/mrvl/mrvl_ethdev.c | 2 ++ >> drivers/net/nfp/nfp_net.c | 2 +- >> drivers/net/null/rte_eth_null.c | 1 + >> drivers/net/octeontx/octeontx_ethdev.c | 2 +- >> drivers/net/pcap/rte_eth_pcap.c | 1 + >> drivers/net/qede/qede_ethdev.c | 2 +- >> drivers/net/ring/rte_eth_ring.c | 1 + >> drivers/net/sfc/sfc_ethdev.c | 2 +- >> drivers/net/szedata2/rte_eth_szedata2.c | 2 +- >> drivers/net/tap/rte_eth_tap.c | 2 +- >> drivers/net/thunderx/nicvf_ethdev.c | 2 +- >> drivers/net/virtio/virtio_ethdev.c | 2 +- >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- >> examples/ethtool/lib/rte_ethtool.c | 15 +++++++++------ >> examples/ip_pipeline/init.c | 10 ++++++++-- >> examples/kni/main.c | 10 +++++++--- >> lib/librte_ether/rte_ethdev.h | 2 +- >> test/test/test_kni.c | 28 ++++++++++++++++++++++------ >> 41 files changed, 114 insertions(+), 54 deletions(-) >> > > [...] > >> diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c >> index c0483b912..d46c65255 100644 >> --- a/drivers/net/mrvl/mrvl_ethdev.c >> +++ b/drivers/net/mrvl/mrvl_ethdev.c >> @@ -1314,6 +1314,8 @@ static void >> mrvl_dev_infos_get(struct rte_eth_dev *dev __rte_unused, >> struct rte_eth_dev_info *info) >> { >> + info->device = dev->device; > > Since dev is used perhaps __rte_unused can be dropped. > Besides that, OK, I will send new version. (reduced cc list)