From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 3/3] net/cxgbe: remove unused variable Date: Wed, 25 Jan 2017 12:15:14 +0000 Message-ID: <7b39bb9f-9e45-8179-fd5f-ec777b97186c@intel.com> References: <20170124204859.8998-1-emmanuel.roullit@gmail.com> <20170124204859.8998-3-emmanuel.roullit@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Emmanuel Roullit , rahul.lakkireddy@chelsio.com Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A99EAB6D for ; Wed, 25 Jan 2017 13:15:17 +0100 (CET) In-Reply-To: <20170124204859.8998-3-emmanuel.roullit@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/24/2017 8:48 PM, Emmanuel Roullit wrote: > Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API") > > Signed-off-by: Emmanuel Roullit > --- > drivers/net/cxgbe/sge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c > index 42051ca01..37b609040 100644 > --- a/drivers/net/cxgbe/sge.c > +++ b/drivers/net/cxgbe/sge.c > @@ -890,7 +890,7 @@ static inline int should_tx_packet_coalesce(struct sge_eth_txq *txq, > struct sge_txq *q = &txq->q; > unsigned int flits, ndesc; > unsigned char type = 0; > - int credits, hw_cidx = ntohs(q->stat->cidx); > + int credits; This depends on patch 2/3, so this patch will wait it to be clarified. > > /* use coal WR type 1 when no frags are present */ > type = (mbuf->nb_segs == 1) ? 1 : 0; >