From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 3/3] net/bnxt: update HWRM API to 1.8.2
Date: Fri, 20 Oct 2017 12:39:30 -0700
Message-ID: <7b5c8ca8-7523-add0-0cca-826278496a19@intel.com>
References: <20171012173521.54626-1-ajit.khaparde@broadcom.com>
 <20171012173521.54626-4-ajit.khaparde@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 456341B29B
 for <dev@dpdk.org>; Fri, 20 Oct 2017 21:39:31 +0200 (CEST)
In-Reply-To: <20171012173521.54626-4-ajit.khaparde@broadcom.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/12/2017 10:35 AM, Ajit Khaparde wrote:
> This patch updates the HWRM APi to version 1.8.2
> This patch is based on an autogenerated file.
> Almost all the changes in the PMD are macro name changes.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt.h                |     2 -
>  drivers/net/bnxt/bnxt_ethdev.c         |     2 +-
>  drivers/net/bnxt/bnxt_hwrm.c           |     2 +-
>  drivers/net/bnxt/bnxt_hwrm.h           |     2 +
>  drivers/net/bnxt/bnxt_irq.c            |     2 +-
>  drivers/net/bnxt/bnxt_rxr.c            |     4 +-
>  drivers/net/bnxt/bnxt_txr.c            |     2 +-
>  drivers/net/bnxt/hsi_struct_def_dpdk.h | 30829 ++++++++++++++++++++++++-------

Only 30K lines of code :)

>  8 files changed, 24374 insertions(+), 6471 deletions(-)

There are some replacement in hsi_struct_def_dpdk.h, but also there are lots of
new additions.
Are those new additions really used within the driver?

What do you think adding structures that are only used by driver?
I am aware code is auto-generated, but it may be possible to add some #ifdefs to
the parts DPDK uses and auto-generate file specific for DPDK?

Thanks,
ferruh