From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: [PATCH 3/3] mk: fail build on incomplete shared library dependencies Date: Tue, 21 Jun 2016 11:11:49 +0300 Message-ID: <7d5dcbf0aeac341ffc922ad972160b5312a30057.1466496709.git.pmatilai@redhat.com> References: Cc: christian.ehrhardt@canonical.com, thomas.monjalon@6wind.com To: dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CD3A5ADCB for ; Tue, 21 Jun 2016 10:12:15 +0200 (CEST) In-Reply-To: In-Reply-To: References: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Require all symbols used by a DSO to be resolvable via LDLIBS at build-time. Previously it was possible to build a library with incomplete dependencies which could then fail at run-time. Signed-off-by: Panu Matilainen --- mk/rte.lib.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 1ff403f..f75ec10 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -94,7 +94,7 @@ O_TO_A_DO = @set -e; \ echo $(O_TO_A_CMD) > $(call exe2cmd,$(@)) O_TO_S = $(LD) -L$(RTE_OUTPUT)/lib $(_CPU_LDFLAGS) $(EXTRA_LDFLAGS) \ - -shared $(OBJS-y) $(LDLIBS) -Wl,-soname,$(LIB) -o $(LIB) + -shared $(OBJS-y) -z defs $(LDLIBS) -Wl,-soname,$(LIB) -o $(LIB) O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)") O_TO_S_DO = @set -e; \ -- 2.5.5