From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH 9/9] tools: use SPDX tag for Cavium copyright
	files
Date: Sun, 7 Jan 2018 14:24:11 +0530
Message-ID: <7d835c29-7400-0b52-287e-6a3d2562c3d0@nxp.com>
References: <20180106122005.20183-1-jerin.jacob@caviumnetworks.com>
 <20180106122005.20183-9-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
 (mail-cys01nam02on0057.outbound.protection.outlook.com [104.47.37.57])
 by dpdk.org (Postfix) with ESMTP id 643633257
 for <dev@dpdk.org>; Sun,  7 Jan 2018 09:54:19 +0100 (CET)
In-Reply-To: <20180106122005.20183-9-jerin.jacob@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/6/2018 5:50 PM, Jerin Jacob wrote:
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  devtools/build-tags.sh | 30 ++----------------------------
>  1 file changed, 2 insertions(+), 28 deletions(-)
>
> diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> index 942da2bae..d775b17e9 100755
> --- a/devtools/build-tags.sh
> +++ b/devtools/build-tags.sh
> @@ -1,35 +1,9 @@
>  #!/bin/sh -e
>  # Generate tags or gtags or cscope or etags files
>  #
> -#   BSD LICENSE
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2017 Cavium, Inc

Hi Jerin,
        All your patches are ok except this one.
It is not aligned with the policy.
SPDX tag shall be in 1st or 2nd line (for !/bin/sh) scripts.

you can move the comments ("Generate tags...") after the copyrights.

Regards,
Hemant