From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH 4/5] net/virtio: remove redundant macro
 definitions for vector Rx
Date: Thu, 7 Dec 2017 10:18:14 +0100
Message-ID: <7de90139-bf6f-24e8-9ab5-c1c666f28ccb@redhat.com>
References: <20171207053059.19487-1-tiwei.bie@intel.com>
 <20171207053059.19487-5-tiwei.bie@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Tiwei Bie <tiwei.bie@intel.com>, yliu@fridaylinux.org, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 2F78E1C00
 for <dev@dpdk.org>; Thu,  7 Dec 2017 10:18:26 +0100 (CET)
In-Reply-To: <20171207053059.19487-5-tiwei.bie@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 12/07/2017 06:30 AM, Tiwei Bie wrote:
> RTE_VIRTIO_VPMD_RX_BURST and RTE_VIRTIO_VPMD_RX_REARM_THRESH
> have been defined and used in virtio_rxtx_simple.h, but are
> defined agained in virtio_rxtx_simple_*.c. It just happens to
s/agained/again/

> work. So remove the redundant definitions from the *.c files.
> 
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   drivers/net/virtio/virtio_rxtx_simple_neon.c | 2 --
>   drivers/net/virtio/virtio_rxtx_simple_sse.c  | 2 --
>   2 files changed, 4 deletions(-)

Apart from above typo:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime