From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 3/5] examples/kni: monitor and update link
 status continually
Date: Mon, 22 Oct 2018 13:51:19 +0100
Message-ID: <7e26ad9a-612d-cf87-6d76-ea36224a5c01@intel.com>
References: <20180911232906.18352-1-dg@adax.com>
 <20181019002358.17132-1-dg@adax.com> <20181019002358.17132-4-dg@adax.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Igor Ryzhov <iryzhov@nfware.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>
To: Dan Gora <dg@adax.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id CC9BD4C9C
 for <dev@dpdk.org>; Mon, 22 Oct 2018 14:51:21 +0200 (CEST)
In-Reply-To: <20181019002358.17132-4-dg@adax.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/19/2018 1:23 AM, Dan Gora wrote:
> Update KNI example to add the command line flag '-m' to enable
> a function to continuously monitor the Ethernet link status of
> the physical link and update the link status of the corresponding
> interfaces with rte_kni_update_link().
> 
> Signed-off-by: Dan Gora <dg@adax.com>

<...>

> +Running the kni Example Application
> +-----------------------------------
>  
> -Loading the KNI kernel module without any parameter is the typical way a DPDK application
> -gets packets into and out of the kernel net stack.
> -This way, only one kernel thread is created for all KNI devices for packet receiving in kernel side:
> +The ``kni`` example application requires a number of command line options:
>  
>  .. code-block:: console
>  
> -    #insmod rte_kni.ko
> +    kni [EAL options] -- -P -p PORTMASK --config="(port,lcore_rx,lcore_tx[,lcore_kthread,...])[,(port,lcore_rx,lcore_tx[,lcore_kthread,...])]"

+ [-m]:

kni [EAL options] -- -P -p PORTMASK
--config="(port,lcore_rx,lcore_tx[,lcore_kthread,...])[,(port,lcore_rx,lcore_tx[,lcore_kthread,...])]"
[-m]

Can be added while merging.

<...>

> -
> -Callbacks for Kernel Requests
> -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> -
> -To execute specific PMD operations in user space requested by some Linux* commands,
> -callbacks must be implemented and filled in the struct rte_kni_ops structure.
> -Currently, setting a new MTU, change in MAC address, configuring promiscusous mode and
> -configuring the network interface(up/down) re supported.
> -Default implementation for following is available in rte_kni library.
> -Application may choose to not implement following callbacks:
> -
> -- ``config_mac_address``
> -- ``config_promiscusity``

I am for keeping this section, is there any specific reason to remove this?